[10.x] Address Null Parameter Deprecations in UrlGenerator #51148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace null values with empty strings for preg_match.
|
Both methods' docblocks state that they expect a string. You can see numerous PR trying to account for nulls like this. If the deprecation notice is triggered by an internal call of those methods, then the call should be fixed, not the implementation to account for unexpected usage. |
Change default header get to empty string.
Updated PR to fix the specific ones I found earlier. |
driesvints
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UrlGenerator can currently receive a null value for
$pathinisValidUrlandextractQueryStringwhich leads to null being passed topreg_matchandstrposrespectively which is deprecated.Resolves #51147